Fix parsing balance in generateCanonicalGenesis #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test case would be fixed after ethereumjs/ethereumjs-common#66 is merged and released. |
|
I restarted the tests on circle, and I don't get why the tests are failing. ethereumjs/ethereumjs-common#66 was already merged and released. |
|
Yeah, I'm wondering too, will look into it now, thanks for restarting the tests |
|
Merged in master, should be fixed now |
alcuadrado
approved these changes
Sep 10, 2019
|
I merged the other PR first and this became out-dated. @alcuadrado can you re-approve after tests pass? |
alcuadrado
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #586
If balances in
ethereumjs-commonare prefixed with0x, they'd have to be parsed as a hex string.Added test cases to ensure generating the genesis state for every chain matches the expected state root. All tests pass, expect for
kovan. Noticed that the genesisState file for kovan is empty in ethereumjs-common.